From 53a25b3be4bbab4586f53b61e54604390f59d512 Mon Sep 17 00:00:00 2001
From: Lorenz Stechauner <lorenz.stechauner@necronda.net>
Date: Thu, 29 Feb 2024 13:03:32 +0100
Subject: [PATCH] ContextWindow: Context has not to be Disposed

https://stackoverflow.com/questions/15666824/entity-framework-and-calling-context-dispose

https://blog.jongallant.com/2012/10/do-i-have-to-call-dispose-on-dbcontext/
---
 Elwig/Windows/ContextWindow.cs   | 7 -------
 Elwig/Windows/MailWindow.xaml.cs | 1 -
 2 files changed, 8 deletions(-)

diff --git a/Elwig/Windows/ContextWindow.cs b/Elwig/Windows/ContextWindow.cs
index f255deb..a2f7e0c 100644
--- a/Elwig/Windows/ContextWindow.cs
+++ b/Elwig/Windows/ContextWindow.cs
@@ -39,18 +39,11 @@ namespace Elwig.Windows {
             await OnRenewContext();
         }
 
-        protected override void OnClosed(EventArgs evt) {
-            base.OnClosed(evt);
-            Context.Dispose();
-        }
-
         protected async Task RenewContext() {
             if (!_renewPending) return;
-            var old = Context;
             Context = new();
             await OnRenewContext();
             _renewPending = false;
-            old.Dispose();
         }
 
         abstract protected Task OnRenewContext();
diff --git a/Elwig/Windows/MailWindow.xaml.cs b/Elwig/Windows/MailWindow.xaml.cs
index 103bdf8..90fe602 100644
--- a/Elwig/Windows/MailWindow.xaml.cs
+++ b/Elwig/Windows/MailWindow.xaml.cs
@@ -273,7 +273,6 @@ namespace Elwig.Windows {
             if (RecipientsCustomInput.IsChecked == true) {
                 Recipients = MemberCustomInput.SelectedItems.Cast<Member>().ToList();
             } else {
-                // FIXME NOT WORKING ON SECOND OPENING OF WINDOW
                 var year = (!await Context.Deliveries.AnyAsync()) ? 0 : await Context.Deliveries.Select(d => d.Year).MaxAsync();
 
                 IQueryable<Member> query = Context.Members.Where(m => m.IsActive);